Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #25353 -- Changed LogEntry.action_time to a "date created". #5233

Merged
merged 1 commit into from Sep 4, 2015

Conversation

Projects
None yet
2 participants
@timgraham

This comment has been minimized.

Copy link
Member Author

commented Sep 4, 2015

Maybe default=timezone.now is a better option.

@charettes

This comment has been minimized.

Copy link
Member

commented Sep 4, 2015

I think default=timezone.now is a better option yes.

@timgraham

This comment has been minimized.

Copy link
Member Author

commented Sep 4, 2015

Oh, it seems that's incompatible with editable=False.

@timgraham timgraham force-pushed the timgraham:25353 branch 2 times, most recently Sep 4, 2015

@timgraham timgraham force-pushed the timgraham:25353 branch to d5bac7e Sep 4, 2015

@timgraham

This comment has been minimized.

Copy link
Member Author

commented Sep 4, 2015

Actually this was caused by model initialization with None for the field in the manager. I think tests should pass now.

@charettes

This comment has been minimized.

Copy link
Member

commented Sep 4, 2015

LGTM assuming tests pass.

@timgraham timgraham merged commit d5bac7e into django:master Sep 4, 2015

5 checks passed

default Build finished. No test results found.
Details
docs Build finished. No test results found.
Details
flake8 Build finished. No test results found.
Details
isort Build finished. No test results found.
Details
javascript Build finished. No test results found.
Details

@timgraham timgraham deleted the timgraham:25353 branch Sep 4, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.