Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #25329 - Don't leave _nodb_connection open #5262

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@adamchainz
Copy link
Member

adamchainz commented Sep 10, 2015

Ticket 25329. Will mean an one extra connection open will occur on a test run.

@timgraham

View changes

django/db/backends/base/base.py Outdated
def _nodb_connection(self):
"""
Alternative connection to be used when there is no need to access
Returns an alternative connection to be used when there is no need to access

This comment has been minimized.

Copy link
@timgraham

timgraham Sep 10, 2015

Member

"Returns" -> "Return" (PEP 257 style for new comments)

@timgraham

This comment has been minimized.

Copy link
Member

timgraham commented Sep 10, 2015

It might be helpful to refer to the original commit when fixing the test failure on PostgreSQL: e953c78.

@adamchainz adamchainz force-pushed the adamchainz:ticket_25329 branch Sep 10, 2015

@adamchainz

This comment has been minimized.

Copy link
Member Author

adamchainz commented Sep 10, 2015

It was just @cached_property left on the postgres backend, an easy fix :)

@adamchainz adamchainz force-pushed the adamchainz:ticket_25329 branch to 89ac74b Sep 10, 2015

@claudep

This comment has been minimized.

Copy link
Member

claudep commented Sep 11, 2015

Thanks, pushed in b2f6e42

@claudep claudep closed this Sep 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.