Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix #19318: Admin's SimpleListFilter option not being displayed as selected if the lookup's first element is not a string #540

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

sebasmagri commented Nov 19, 2012

This pull request contains the fix for 1.5.x.

The lookup value is coerced to text by using force_text

@sebasmagri sebasmagri Coerce lookup value to text in SimpleListFilter.choices
    This fixes #19318, where the filter option might not have set
    its selected class when active if using integers as option
    value
295cdfa
Owner

aaugustin commented Nov 19, 2012

This commit contains strings with the u prefix which is a syntax error under Python 3.

Contributor

sebasmagri commented Nov 19, 2012

I'm sorry.

I have fixed the commit for 1.5.x.

Member

jphalip commented Dec 4, 2012

Fixed in 237a404. Thanks!

@jphalip jphalip closed this Dec 4, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment