Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fixed #19314 -- contrib.admin send signal on add_row #542

Closed
wants to merge 28 commits into from
@per42

When a user clicks add_row after some inlines in admin, a django.signal
is sent with the new form's DOM element. This can be used by widgets
that need to run some javascript when they have been added to the DOM.

https://code.djangoproject.com/ticket/19314

tomchristie and others added some commits
@tomchristie tomchristie Add 'page_kwarg' attribute to `MultipleObjectMixin`, removing hardcod…
…ed 'page'.
502be86
@tomchristie tomchristie Test for `ListView.page_kwarg` f824a95
@kenthauser kenthauser Add `form` to formwizard context (includes tests) ba81164
@gabrielhurley gabrielhurley Fixed #18210 -- Escaped special characters in reverse prefixes.
Ensured that special characters passed in to reverse via the
prefix argument are properly escaped so that calls to
django.utils.regex_helpers.normalize and/or string formatting
operations don't result in exceptions.

Thanks to toofishes for the error report.
90e5309
@tomchristie tomchristie Include `versionadded 1.5` directive 5bc6929
@tomchristie tomchristie Formatting tweaks. 3f2fc2f
@jezdez jezdez Fixed #19136 -- Properly escape gettext context prefixes in the i18n …
…JavaScript view template.
4a5e808
@jezdez jezdez Merge branch 'master' of github.com:django/django b884802
@jezdez jezdez Merge pull request #490 from gabrielhurley/reverse-prefix-special-chars
Fixed #18210 -- Escaped special characters in reverse prefixes.
233f864
@jezdez jezdez Fixed typo introduced in 4a5e808. f790138
@ptone ptone Fixed #19310 -- changed method docs formatting for custom file storag…
…e docs
7a38e86
@claudep claudep Fixed #18989 -- Removed unused condition in CursorWrapper
Thanks zimnyx for the report.
8c69278
@claudep claudep Fixed #19226 -- Applied linebreaksbr to read-only fields in admin
Thanks shadow for the report, and Melevir and thiderman for the
patch.
ec9d6b1
@ramiro ramiro Refactor loaddata for readability.
Thanks Claude Paroz and Daniel Moisset for review and feedback.
9e7723f
@claudep claudep Fixed #19036 -- Fixed base64 uploads decoding
Thanks anthony at adsorbtion.org for the report, and johannesl for
bringing the patch up-to-date.
2a67374
@claudep claudep Fixed #19114 -- Fixed LogEntry unicode representation
Thanks niko at neagee.net for the report and Emil Stenstrom for
the patch.
e0363c6
@timgraham timgraham Fixed #16779 - Added a contributing tutorial
Thank-you Taavi Taijala for the draft patch!
7058b59
@jezdez jezdez Fixed #2550 -- Allow the auth backends to raise the PermissionDenied …
…exception to completely stop the authentication chain. Many thanks to namn, danielr, Dan Julius, Łukasz Rekucki, Aashu Dwivedi and umbrae for working this over the years.
1520748
@jezdez jezdez Merge pull request #466 from kenthauser/ticket_19025
#19025 Add `form` to formwizard context (includes tests)
7309770
@jezdez jezdez Merge pull request #467 from tomchristie/page-kwarg
Add 'page_kwarg' attribute to `MultipleObjectMixin`, removing hardcoded "page".
778b8bd
@aaugustin aaugustin Fixed #19291 -- Completed deprecation of ADMIN_MEDIA_PREFIX. 9b755a2
@aaugustin aaugustin Fix typo in file storage docs. 4585e12
@aaugustin aaugustin Fixed #19315 -- Improved markup in admin FAQ.
Thanks ClaesBas.
ccb2b57
@timgraham timgraham Fixed #13997 - Added an example of constructing a MultiWidget and doc…
…umented the value_from_datadict method.
04775b4
@timgraham timgraham Fixed #19308 - Clarified stringformat filter example
Thanks Shabda Raaj.
2564e31
@timgraham timgraham Fixed #19306 - Improved syndication example.
Thanks brycenesbitt for the report.
1f1f60d
@per42 per42 Fixed #19314 -- contrib.admin send signal on add_row
When a user clicks add_row after some inlines in admin, a django.signal
is sent with the new form's DOM element. This can be used by widgets
that need to run some javascript when they have been added to the DOM.
bc0aad3
@per42

This only patches the source js. What tool should I use to minimize it?

@per42 per42 Fixed #15760 -- delete event + documentation
This patch was first built for a duplicate of #15760. It is now adapted
to fix #15760 instead.
1c917f6
@ludwigkraatz

\@skipIfCustomUser

is missing currently

@timgraham
Owner

Are you interested in writing some tests for this so we can merge it?

Instructions for javascript minification are here:
https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/submitting-patches/#compressing-javascript

@timgraham
Owner

This PR needs to be reworked so it doesn't include unrelated commits (caused by when someone accidentally force pushed to (django/django)). It also needs updates as noted above and in the ticket.

@timgraham timgraham closed this
@timmyomahony

Did this ever make it into the master branch? I can't see any sort of event triggering with django's admin inlines which is really limiting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 25, 2012
  1. @tomchristie
  2. @tomchristie
Commits on Oct 31, 2012
  1. @kenthauser
Commits on Nov 3, 2012
  1. @gabrielhurley

    Fixed #18210 -- Escaped special characters in reverse prefixes.

    gabrielhurley authored
    Ensured that special characters passed in to reverse via the
    prefix argument are properly escaped so that calls to
    django.utils.regex_helpers.normalize and/or string formatting
    operations don't result in exceptions.
    
    Thanks to toofishes for the error report.
Commits on Nov 9, 2012
  1. @tomchristie
  2. @tomchristie

    Formatting tweaks.

    tomchristie authored
Commits on Nov 17, 2012
  1. @jezdez

    Fixed #19136 -- Properly escape gettext context prefixes in the i18n …

    jezdez authored
    …JavaScript view template.
  2. @jezdez
  3. @jezdez

    Merge pull request #490 from gabrielhurley/reverse-prefix-special-chars

    jezdez authored
    Fixed #18210 -- Escaped special characters in reverse prefixes.
  4. @jezdez

    Fixed typo introduced in 4a5e808.

    jezdez authored
  5. @ptone
  6. @claudep

    Fixed #18989 -- Removed unused condition in CursorWrapper

    claudep authored
    Thanks zimnyx for the report.
  7. @claudep

    Fixed #19226 -- Applied linebreaksbr to read-only fields in admin

    claudep authored
    Thanks shadow for the report, and Melevir and thiderman for the
    patch.
  8. @ramiro

    Refactor loaddata for readability.

    ramiro authored
    Thanks Claude Paroz and Daniel Moisset for review and feedback.
  9. @claudep

    Fixed #19036 -- Fixed base64 uploads decoding

    claudep authored
    Thanks anthony at adsorbtion.org for the report, and johannesl for
    bringing the patch up-to-date.
  10. @claudep

    Fixed #19114 -- Fixed LogEntry unicode representation

    claudep authored
    Thanks niko at neagee.net for the report and Emil Stenstrom for
    the patch.
  11. @timgraham

    Fixed #16779 - Added a contributing tutorial

    timgraham authored
    Thank-you Taavi Taijala for the draft patch!
  12. @jezdez

    Fixed #2550 -- Allow the auth backends to raise the PermissionDenied …

    jezdez authored
    …exception to completely stop the authentication chain. Many thanks to namn, danielr, Dan Julius, Łukasz Rekucki, Aashu Dwivedi and umbrae for working this over the years.
  13. @jezdez

    Merge pull request #466 from kenthauser/ticket_19025

    jezdez authored
    #19025 Add `form` to formwizard context (includes tests)
  14. @jezdez

    Merge pull request #467 from tomchristie/page-kwarg

    jezdez authored
    Add 'page_kwarg' attribute to `MultipleObjectMixin`, removing hardcoded "page".
  15. @aaugustin
  16. @aaugustin
  17. @aaugustin

    Fixed #19315 -- Improved markup in admin FAQ.

    aaugustin authored
    Thanks ClaesBas.
  18. @timgraham

    Fixed #13997 - Added an example of constructing a MultiWidget and doc…

    timgraham authored
    …umented the value_from_datadict method.
Commits on Nov 18, 2012
  1. @timgraham

    Fixed #19308 - Clarified stringformat filter example

    timgraham authored
    Thanks Shabda Raaj.
  2. @timgraham

    Fixed #19306 - Improved syndication example.

    timgraham authored
    Thanks brycenesbitt for the report.
Commits on Nov 19, 2012
  1. @per42

    Fixed #19314 -- contrib.admin send signal on add_row

    per42 authored
    When a user clicks add_row after some inlines in admin, a django.signal
    is sent with the new form's DOM element. This can be used by widgets
    that need to run some javascript when they have been added to the DOM.
  2. @per42

    Fixed #15760 -- delete event + documentation

    per42 authored
    This patch was first built for a duplicate of #15760. It is now adapted
    to fix #15760 instead.
Something went wrong with that request. Please try again.