Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #19314 -- contrib.admin send signal on add_row #542

Closed
wants to merge 28 commits into from

Conversation

Projects
None yet
@per42
Copy link

commented Nov 19, 2012

When a user clicks add_row after some inlines in admin, a django.signal
is sent with the new form's DOM element. This can be used by widgets
that need to run some javascript when they have been added to the DOM.

https://code.djangoproject.com/ticket/19314

tomchristie and others added some commits Oct 25, 2012

Fixed #18210 -- Escaped special characters in reverse prefixes.
Ensured that special characters passed in to reverse via the
prefix argument are properly escaped so that calls to
django.utils.regex_helpers.normalize and/or string formatting
operations don't result in exceptions.

Thanks to toofishes for the error report.
Merge pull request #490 from gabrielhurley/reverse-prefix-special-chars
Fixed #18210 -- Escaped special characters in reverse prefixes.
Fixed #19226 -- Applied linebreaksbr to read-only fields in admin
Thanks shadow for the report, and Melevir and thiderman for the
patch.
Refactor loaddata for readability.
Thanks Claude Paroz and Daniel Moisset for review and feedback.
Fixed #19036 -- Fixed base64 uploads decoding
Thanks anthony at adsorbtion.org for the report, and johannesl for
bringing the patch up-to-date.
Fixed #19114 -- Fixed LogEntry unicode representation
Thanks niko at neagee.net for the report and Emil Stenstrom for
the patch.
Fixed #16779 - Added a contributing tutorial
Thank-you Taavi Taijala for the draft patch!
Fixed #2550 -- Allow the auth backends to raise the PermissionDenied …
…exception to completely stop the authentication chain. Many thanks to namn, danielr, Dan Julius, Łukasz Rekucki, Aashu Dwivedi and umbrae for working this over the years.
Merge pull request #466 from kenthauser/ticket_19025
#19025 Add `form` to formwizard context (includes tests)
Merge pull request #467 from tomchristie/page-kwarg
Add 'page_kwarg' attribute to `MultipleObjectMixin`, removing hardcoded "page".
Fixed #19306 - Improved syndication example.
Thanks brycenesbitt for the report.
Fixed #19314 -- contrib.admin send signal on add_row
When a user clicks add_row after some inlines in admin, a django.signal
is sent with the new form's DOM element. This can be used by widgets
that need to run some javascript when they have been added to the DOM.
@per42

This comment has been minimized.

Copy link
Author

commented Nov 19, 2012

This only patches the source js. What tool should I use to minimize it?

@per42

This comment has been minimized.

Copy link
Author

commented Nov 19, 2012

Fixed #15760 -- delete event + documentation
This patch was first built for a duplicate of #15760. It is now adapted
to fix #15760 instead.
@ludwigkraatz

This comment has been minimized.

@skipIfCustomUser

is missing currently

@timgraham

This comment has been minimized.

Copy link
Member

commented Oct 17, 2013

Are you interested in writing some tests for this so we can merge it?

Instructions for javascript minification are here:
https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/submitting-patches/#compressing-javascript

@timgraham

This comment has been minimized.

Copy link
Member

commented Feb 7, 2014

This PR needs to be reworked so it doesn't include unrelated commits (caused by when someone accidentally force pushed to (django/django)). It also needs updates as noted above and in the ticket.

@timgraham timgraham closed this Feb 7, 2014

@timmyomahony

This comment has been minimized.

Copy link

commented on bc0aad3 Mar 13, 2014

Did this ever make it into the master branch? I can't see any sort of event triggering with django's admin inlines which is really limiting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.