Fixed #9962 - Added a testing tutorial. #548

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
Owner

timgraham commented Nov 22, 2012

Thank-you Daniele Procida!

Fixed #9962 - Added a testing tutorial.
Thank-you Daniele Procida!

The part about reusable apps references part 4 of the tutorial, and it should probably also be changed to reference part 5 when this change is applied.

This is still a bug -- timezone.now() is called at the time urls.py is imported; so it selects not the polls published before the request time, but those published before the last time the server started. To fix it, drop the ():

queryset=Poll.objects.filter(pub_date__lte=timezone.now) \

Owner

timgraham replied Dec 1, 2012

Good catch, I'll make this fix and add a note about that gotcha. Appreciate your review!

Same problem as above -- timezone.now called at definition time, not execution time.

This repetition of the code quoted only a few lines above is redundant IMO.

shaib commented on f9395b0 Dec 1, 2012

My comments above notwithstanding, I think adding this tutorial is a great idea and the current offering is very good.

@timgraham timgraham closed this Dec 15, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment