Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

intword and intabr expansion and intword_internal api exposure #578

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
3 participants

eire1130 commented Dec 9, 2012

No description provided.

Owner

apollo13 commented Dec 11, 2012

Where is an accepted ticket for this change?

Ticket is here: https://code.djangoproject.com/ticket/19447

It's not accepted. Hasn't been reviewed yet. I announced this pull request in the ticket.

@apollo13 apollo13 commented on the diff Dec 30, 2012

docs/ref/contrib/humanize.txt
@@ -67,6 +67,11 @@ Examples:
Values up to 10^100 (Googol) are supported.
+**Argument:** intword can take a precision argument. Default is a precision
+of 1, for example a precision of 2:
+
+* ``1234000`` becomes ``1.23 million``.
@apollo13

apollo13 Dec 30, 2012

Owner

Shouldn't this be 1.23 millions (plural!)? The rest to fix is as described by Russell in the ticket.

@kmtracey

kmtracey Dec 30, 2012

Member

No, 1.23 million is correct for English. See "Plurals of numbers" in http://en.wikipedia.org/wiki/English_plural: 'When modified by a number, the plural is not inflected, that is, has no -s added. Hence one hundred, two million, four score, etc."

@eire1130

eire1130 Jan 1, 2013

Per the ticket, Russell had a few questions and I responded to them. I'm waiting on his decisions based on my responses.

For the moment, the only thing that I know of that needs immediate change is changing the name from intabr to intabbr; however, I've been holding off in case I need to make other changes.

@eire1130 eire1130 closed this May 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment