New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #25878 -- Fixed APPEND_SLASH if the project contains an invalid 404.html template. #5903

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@timgraham
Copy link
Member

timgraham commented Dec 31, 2015

https://code.djangoproject.com/ticket/25878

(likely needs an additional test)

@kuna

This comment has been minimized.

Copy link

kuna commented Dec 31, 2015

Oh I just saw it now, thanks for patching :). Is all test failures are solved?

@timgraham

This comment has been minimized.

Copy link
Member Author

timgraham commented Dec 31, 2015

Yes, I added the redirect_with_host variable to fix the other failures mentioned on the ticket.

@timgraham timgraham force-pushed the timgraham:25878 branch from 4e8ab59 to fee1b2d Dec 31, 2015

@timgraham

This comment has been minimized.

Copy link
Member Author

timgraham commented Dec 31, 2015

As noted on the ticket, I don't think I'll move forward with this solution as the actual cause of problems seems to be developer error which we just need to do a better job of reporting.

@timgraham timgraham closed this Dec 31, 2015

@timgraham timgraham deleted the timgraham:25878 branch Jan 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment