Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #22268 : Document values_list() behavior for ManyToManyField #5976

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@saivnm5
Copy link

commented Jan 13, 2016

Added an example in the values_list() reference to illustrate the behavior discussed in the ticket #22268

https://code.djangoproject.com/ticket/22268

Fixed #22268 : Document values_list() behavior for ManyToManyField
Document: reference->models->querysets
Added an example in the values_list() reference to illustrate the behavior discussed in the ticket #22268
https://code.djangoproject.com/ticket/22268
@timgraham

This comment has been minimized.

Copy link
Member

commented Jan 23, 2016

  1. Please wrap documentation lines at 79 characters.
  2. I think "reverse relations" isn't the correct description -- for example, reverse OneToOneField wouldn't suffer from the problem. Rather it's any relation that's 1:N. I think the docs call this a "multivalued relation".
  3. Maybe we could include some of Russ's explanation here (second paragraph): https://groups.google.com/d/msg/django-developers/DAslY6GI1O8/e8drm16jIDYJ
  4. I'm not sure the current example clarifies the None issue very well. I think one with Entry.objects.values_list('authors') would do that better? The current example seems okay for showing the issue with reverse relations though.
@timgraham

This comment has been minimized.

Copy link
Member

commented Feb 2, 2016

Please send a new PR if you can update this, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.