New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #25910 - Don't accept read-only property names in model ctors. #6011

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@xlq
Contributor

xlq commented Jan 22, 2016

This fixes the problem by only removing the item from kwargs after it has been determined that AttributeError isn't raised (e.g. due to trying to assign to a read-only property).

@timgraham

This comment has been minimized.

Show comment
Hide comment
@timgraham

timgraham Jan 22, 2016

Member

merged in 16baec5, thanks!

Member

timgraham commented Jan 22, 2016

merged in 16baec5, thanks!

@timgraham timgraham closed this Jan 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment