Optimize MySQL model.save() in inheritance cases #61

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
1 participant
@akaariai
Member

akaariai commented May 12, 2012

MySQL generated non-necessary queries when saving a multitable
inherited model, and when the save resulted in update.

This issue is tracked in ticket #18304

@akaariai

This comment has been minimized.

Show comment
Hide comment
@akaariai

akaariai May 13, 2012

Member

cramm raised a good point in #django-dev - the issue is described as MySQL specific, but it is actually about "update_can_self_select". MySQL just happens to be the only core database backend with that problem. I will update the commit message.

Member

akaariai commented May 13, 2012

cramm raised a good point in #django-dev - the issue is described as MySQL specific, but it is actually about "update_can_self_select". MySQL just happens to be the only core database backend with that problem. I will update the commit message.

Fixed #18304 -- Optimized save() when update_can_self_select=False
Databases with update_can_self_select = False (MySQL for example)
generated non-necessary queries when saving a multitable inherited
model, and when the save resulted in update.
@akaariai

This comment has been minimized.

Show comment
Hide comment
@akaariai

akaariai May 22, 2012

Member

Pulled in manually in d5c7f9e

Member

akaariai commented May 22, 2012

Pulled in manually in d5c7f9e

@akaariai akaariai closed this May 22, 2012

nanuxbe pushed a commit to nanuxbe/django that referenced this pull request Jul 2, 2016

Merge pull request #61 from coderanger/master
Misc stuff for a multi-server universe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment