New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger request_finished in the WSGI iterable's close(). #612

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@aaugustin
Member

aaugustin commented Dec 30, 2012

No description provided.

@akaariai

View changes

django/test/simple.py Outdated
# Disconnect the signal that was connected in django.db
# (imported above) so the database connection stays open.
signals.request_finished.disconnect(close_connection)

This comment has been minimized.

@akaariai

akaariai Dec 30, 2012

Member

Should this be done as part of running the tests instead of doing it as side effect of import. I am wondering if somebody could import the django.test.simple without running tests.

This comment has been minimized.

@aaugustin

aaugustin Dec 30, 2012

Member

Indeed, that's quite a footgun. I will see if it can be done in a better way.

@aaugustin

This comment has been minimized.

Member

aaugustin commented Dec 31, 2012

Merged today.

@aaugustin aaugustin closed this Dec 31, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment