Trigger request_finished in the WSGI iterable's close(). #612

wants to merge 3 commits into


None yet

2 participants

Django member

No description provided.

@akaariai akaariai and 1 other commented on an outdated diff Dec 30, 2012
@@ -17,6 +19,10 @@
doctestOutputChecker = OutputChecker()
+# Disconnect the signal that was connected in django.db
+# (imported above) so the database connection stays open.
akaariai Dec 30, 2012 Django member

Should this be done as part of running the tests instead of doing it as side effect of import. I am wondering if somebody could import the django.test.simple without running tests.

aaugustin Dec 30, 2012 Django member

Indeed, that's quite a footgun. I will see if it can be done in a better way.

Django member

Merged today.

@aaugustin aaugustin closed this Dec 31, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment