New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #25687 -- Documented how to add database function support to third-party backends. #6136

Merged
merged 1 commit into from Feb 17, 2016

Conversation

Projects
None yet
2 participants
@timgraham
Member

timgraham commented Feb 12, 2016

Updated from #5574.

@claudep

This comment has been minimized.

Show comment
Hide comment
@claudep

claudep Feb 13, 2016

Member

I'd rather replace microsoft by sqlserver in the function names and variables.

Member

claudep commented Feb 13, 2016

I'd rather replace microsoft by sqlserver in the function names and variables.

@timgraham

This comment has been minimized.

Show comment
Hide comment
@timgraham

timgraham Feb 15, 2016

Member

This is copied from django-mssql but I'd be okay with it, although in my mind "Microsoft" is the vendor, not "SQL Server." Of course this could be problematic as Microsoft might have several database offerings.

Member

timgraham commented Feb 15, 2016

This is copied from django-mssql but I'd be okay with it, although in my mind "Microsoft" is the vendor, not "SQL Server." Of course this could be problematic as Microsoft might have several database offerings.

@claudep

This comment has been minimized.

Show comment
Hide comment
@claudep

claudep Feb 15, 2016

Member

Yes, MS Access comes to mind. We have the precedent of Oracle, which is both a company name and a product. As for me, the database product name makes more sense for the vendor property. But I wouldn't fight for it.

Member

claudep commented Feb 15, 2016

Yes, MS Access comes to mind. We have the precedent of Oracle, which is both a company name and a product. As for me, the database product name makes more sense for the vendor property. But I wouldn't fight for it.

Fixed #25687 -- Documented how to add database function support to th…
…ird-party backends.

Thanks Kristof Claes for the initial patch.

@timgraham timgraham merged commit 88034c9 into django:master Feb 17, 2016

@timgraham timgraham deleted the timgraham:25687 branch Feb 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment