Updated staticfiles.views.serve to serve files from another document_root #621

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

ostcar commented Jan 5, 2013

The function django.contrib.staticfiles.views.serve has the argument 'document_root'. But this argument is never read in the function.

You should either remove this argument from the function declaration, or build the final path from it.

Owner

apollo13 commented Jan 7, 2013

Your are obviously right that the document_root argument is unused. But I don't think there is much point in supporting document_root in this view at all. Could you please open a ticket so we can get more feedback on this? Thx.

apollo13 closed this Jan 7, 2013

@nanuxbe nanuxbe pushed a commit to nanuxbe/django that referenced this pull request Jul 2, 2016

@rfleschenberg @timgraham rfleschenberg + timgraham Refs #621 -- Changed <link> tag for English docs to use hreflang="x-d…
…efault".
0ac648b

@nanuxbe nanuxbe pushed a commit to nanuxbe/django that referenced this pull request Jul 2, 2016

@timgraham Piotr Gnus + timgraham Refs #621 -- Used docs translation language in <html> tag. ac468be

@nanuxbe nanuxbe pushed a commit to nanuxbe/django that referenced this pull request Jul 2, 2016

@apollo13 apollo13 Refs #621 -- Keep hreflang en and x-default to make google happy. 3322b34

@nanuxbe nanuxbe pushed a commit to nanuxbe/django that referenced this pull request Jul 2, 2016

@apollo13 apollo13 Refs #621 -- Only use hreflang on the canonical url. d6a966f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment