Skip to content

Fixed #17257 -- Comment that contradicts code in django.contrib.syndication.views #63

Closed
wants to merge 1 commit into from

3 participants

@httpdss
httpdss commented May 13, 2012

Easy picking ticket and testing how this github workflow works out ;)

@lqc
lqc commented May 14, 2012

How does this differ from the patch that is already attached to the ticket ? Quoting aaugustin:

Do you have some evidence that removing the comment is actually the right thing to do?

I didn't commit the fix right away because I wasn't sure of that.

@httpdss
httpdss commented May 15, 2012

there is no difference to the submitted patch, just checking on github workflow with something very simple.

i've tested iri_to_uri and works as expected so I personally think the comment was misleading.

@aaugustin
Django member

The patch was committed in 8dafd04.

@aaugustin aaugustin closed this Jul 8, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.