Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fixed #17257 -- Comment that contradicts code in django.contrib.syndication.views #63

Closed
wants to merge 1 commit into from

3 participants

@httpdss

Easy picking ticket and testing how this github workflow works out ;)

@lqc

How does this differ from the patch that is already attached to the ticket ? Quoting aaugustin:

Do you have some evidence that removing the comment is actually the right thing to do?

I didn't commit the fix right away because I wasn't sure of that.

@httpdss

there is no difference to the submitted patch, just checking on github workflow with something very simple.

i've tested iri_to_uri and works as expected so I personally think the comment was misleading.

@aaugustin
Owner

The patch was committed in 8dafd04.

@aaugustin aaugustin closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on May 13, 2012
  1. @httpdss
This page is out of date. Refresh to see the latest.
Showing with 0 additions and 2 deletions.
  1. +0 −2  django/contrib/syndication/views.py
View
2  django/contrib/syndication/views.py
@@ -16,8 +16,6 @@ def add_domain(domain, url, secure=False):
elif not (url.startswith('http://')
or url.startswith('https://')
or url.startswith('mailto:')):
- # 'url' must already be ASCII and URL-quoted, so no need for encoding
- # conversions here.
url = iri_to_uri(u'%s://%s%s' % (protocol, domain, url))
return url
Something went wrong with that request. Please try again.