New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #21548 -- Added FileExtensionValidator and validate_image_file_extension validators. #6343

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@berkerpeksag
Contributor

berkerpeksag commented Mar 26, 2016

Show outdated Hide outdated django/forms/fields.py Outdated
Show outdated Hide outdated docs/ref/validators.txt Outdated
@berkerpeksag

This comment has been minimized.

Show comment
Hide comment
@berkerpeksag

berkerpeksag May 15, 2016

Contributor

I have just updated my PR. Thanks for the review, Tim.

Contributor

berkerpeksag commented May 15, 2016

I have just updated my PR. Thanks for the review, Tim.

Show outdated Hide outdated docs/ref/validators.txt Outdated
Show outdated Hide outdated django/core/validators.py Outdated
Show outdated Hide outdated docs/ref/validators.txt Outdated
@timgraham

This comment has been minimized.

Show comment
Hide comment
@timgraham

timgraham Jun 29, 2016

Member

DId you consider the name validate_image_file_extension? I worry that without "extension" it's implied that some deeper inspection of the file is done.

Member

timgraham commented Jun 29, 2016

DId you consider the name validate_image_file_extension? I worry that without "extension" it's implied that some deeper inspection of the file is done.

@timgraham

This comment has been minimized.

Show comment
Hide comment
@timgraham
Member

timgraham commented Jun 29, 2016

A few more edits: http://dpaste.com/2VTEN20

@berkerpeksag berkerpeksag changed the title from Fixed #21548 -- Added FileExtensionValidator and validate_image_file validators. to Fixed #21548 -- Added FileExtensionValidator and validate_image_file_extension validators. Jun 30, 2016

@berkerpeksag

This comment has been minimized.

Show comment
Hide comment
@berkerpeksag

berkerpeksag Jun 30, 2016

Contributor

validate_image_file_extension is much better. Renamed it to validate_image_file_extension, added test for it, and applied your edits.

Thanks!

Contributor

berkerpeksag commented Jun 30, 2016

validate_image_file_extension is much better. Renamed it to validate_image_file_extension, added test for it, and applied your edits.

Thanks!

@timgraham

This comment has been minimized.

Show comment
Hide comment
@timgraham

timgraham Jun 30, 2016

Member

merged in 12b4280, thanks!

Member

timgraham commented Jun 30, 2016

merged in 12b4280, thanks!

@timgraham timgraham closed this Jun 30, 2016

@berkerpeksag berkerpeksag deleted the berkerpeksag:21548-file-ext-validator branch Jun 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment