New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #22383 -- Added support for HTML5 required attribute on required form fields. #6352

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@jdufresne
Member

jdufresne commented Mar 28, 2016

https://code.djangoproject.com/ticket/22383

Same as PR #6341 but without the deprecation cycle.

@timgraham

This comment has been minimized.

Show comment
Hide comment
@timgraham

timgraham Apr 13, 2016

Member

Please check the docs for rendered form examples that might need to be updated, e.g. docs/topics/forms/index.txt.

Member

timgraham commented Apr 13, 2016

Please check the docs for rendered form examples that might need to be updated, e.g. docs/topics/forms/index.txt.

@jdufresne

This comment has been minimized.

Show comment
Hide comment
@jdufresne

jdufresne Apr 21, 2016

Member

I have addressed the concern. All additional feedback is welcome. Thanks.

Should explain how this works for formsets somewhere. Maybe here and elsewhere?

Added some text to ref/forms/api.txt and to topics/forms/formsets.txt. Please let me know what you think and if this addresses what you had in mind.

Please check the docs for rendered form examples that might need to be updated, e.g. docs/topics/forms/index.txt.

Done. This resulted in changes to:

  • refs/forms/api.txt
  • refs/forms/fields.txt
  • refs/forms/widgets.txt
  • topics/forms/index.txt
Member

jdufresne commented Apr 21, 2016

I have addressed the concern. All additional feedback is welcome. Thanks.

Should explain how this works for formsets somewhere. Maybe here and elsewhere?

Added some text to ref/forms/api.txt and to topics/forms/formsets.txt. Please let me know what you think and if this addresses what you had in mind.

Please check the docs for rendered form examples that might need to be updated, e.g. docs/topics/forms/index.txt.

Done. This resulted in changes to:

  • refs/forms/api.txt
  • refs/forms/fields.txt
  • refs/forms/widgets.txt
  • topics/forms/index.txt
@timgraham

This comment has been minimized.

Show comment
Hide comment
@timgraham

timgraham Apr 21, 2016

Member

merged in ec61216, thanks!

Member

timgraham commented Apr 21, 2016

merged in ec61216, thanks!

@timgraham timgraham closed this Apr 21, 2016

@jdufresne jdufresne deleted the jdufresne:html5-required-no-warning branch May 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment