sqldiff fails with PointField declaration #670

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Member

charettes commented Jan 24, 2013

Hi @johnraz, please [https://code.djangoproject.com/newticket file a ticket] or link to the current one. Also, in order to be checked in this patch needs a failing test case.

johnraz commented Jan 24, 2013

@charettes : the link to the ticket was in the pull request comments already ;-)
Will work on a failing test case asap.

Member

charettes commented Jan 24, 2013

@johnraz, oh.. sorry about that, didn't notice :)

Member

charettes commented Jan 24, 2013

By the way, "%s" % None == 'None' so I think the patch is not correct in this case. Maybe a (text if text else '', RESET) with no string format will do in this case. Note that as of PEP8 you should put a space between tuple elements here.

johnraz commented Jan 24, 2013

No problem, thanks for pointing this out, this has no side effect on my end but it's indeed not correct.
I'll review all this along with the failling test case.

What aboout :
(text or '', RESET)

Member

charettes commented Jan 24, 2013

That looks better than the if statement.

johnraz commented Jan 24, 2013

@charretes : please find the failing test case along with the patch in the new pull request #671
Hope it covers it ;)

johnraz commented Jan 24, 2013

I guess I can close this one btw.

johnraz closed this Jan 24, 2013

@ramiro ramiro pushed a commit to ramiro/django that referenced this pull request Jul 2, 2017

@nanuxbe @bmispelon nanuxbe + bmispelon Fixed #670 -- Added a `messages` block to the main template
Also overridden said block for existing messages in fundraising/index and fundraising/manage-donations
7e4e023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment