Fixed #26778 -- Fixed ModelSignal.connect() weak argument. #6802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pass | ||
| signals.pre_init.connect(callback) | ||
| signals.pre_init.disconnect(callback) | ||
| self.assertTrue(ref.called) |
There was a problem hiding this comment.
I'd use ref.assert_called_once_with() here.
There was a problem hiding this comment.
I wasn't sure how to get the appropriate arguments:
ref.assert_called_once_with(callback)
AssertionError: Expected call: ref(<function callback at 0x7f1de47ec500>)
Actual call: ref(<function callback at 0x7f1de47ec500>,
<bound method ModelSignal._remove_receiver of
<django.db.models.signals.ModelSignal object at 0x7f1de706d4d0>>)
There was a problem hiding this comment.
From looking at the code the call could differ from Python 2 to 3 and is really an implementation detail which is not worth testing after all.
My initial reflexion was more about the fact assert_not_called() was used below instead of self.assertFalse(ref.called) but now I realize there's no assert_called() method.
LGTM
|
LGTM otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://code.djangoproject.com/ticket/26778