Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixed #27392 -- Removed "Tests that", "Ensures that", etc. from test docstrings. #7439
referenced this pull request
Oct 29, 2016
For a recap:
@timgraham I'm done and waiting for review.
@za I ran a more generic search on the /test/ directory in master (used " that " with spaces instead of the more specific "Tests that", etc...) and found other occurrences that you might have missed (i.e. "Verifies that"... etc).
If you don't mind running the more generic search and fixing the remaining strings, and also squashing your commits and updating the PR, you can make this PR more checkin-ready.
Hi @thatdocslady ! Yes, sure I'll be happy to make a PR which is more checkin-ready. I have a question. When there was an update on master, instead of:
I was doing:
Should I re-work my PR (make another new branch and make another changes) because of this? cc: @timgraham
Thanks for your work. I had to proofread the patch fairly carefully as there were some sentences that weren't reworded correctly. I left a comment on the ticket about some additional phrases that could be fixed up. If you work on it, please take a look at the committed patch to get a sense of my edits so I don't have to do similar cleanups again.