Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #56 -- Add Positive AutoFields #8183

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@collinanderson
Copy link
Contributor

commented Mar 15, 2017

@charettes

This comment has been minimized.

Copy link
Member

commented Mar 15, 2017

'PositiveBigIntegerField' will need to be added to each backendsops.integer_field_ranges and tests for this new range will need to be added as well.

@collinanderson collinanderson force-pushed the collinanderson:ticket56 branch 4 times, most recently from 384b6d7 to 32c770e Mar 16, 2017

@collinanderson

This comment has been minimized.

Copy link
Contributor Author

commented Apr 8, 2017

I've added the ranges to ops.integer_field_ranges for each backend and added a test for the new range.

@timgraham

This comment has been minimized.

Copy link
Member

commented Jun 13, 2017

Do you want to ask on the mailing list if there's consensus about this? I'd like a few +1's before adding new model fields. For the backends that allow it, data_type_check_constraints should be modified to prohibit negative values.

@collinanderson collinanderson force-pushed the collinanderson:ticket56 branch from 32c770e to 00e1d21 Aug 16, 2017

@collinanderson

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2017

I don't plan on trying to push this through before Sept 18th.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.