New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #27923 -- Added signals related to form. #8280

Open
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@luojiebin

luojiebin commented Apr 1, 2017

Added six signals that are useful for form: pre_init, post_init, pre_clean,
post_clean, pre_save, post_save.

@luojiebin

This comment has been minimized.

luojiebin commented Apr 1, 2017

I have no idea why there are the warnings like this:
WARNING: py:meth reference target not found: django.forms.forms.BaseForm.full_clean

Can anyone give some advices?

@timgraham

This comment has been minimized.

Member

timgraham commented Apr 1, 2017

Use Form instead of BaseForm to fix the warnings. Also, I think writing the patch was a bit premature. As I said on the ticket, we should get some consensus on the django-developers mailing list about which signals to add and their arguments. Well, you can share this there now, I guess. The thread is linked in the ticket's description.

Please also use the patch review checklist to review your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment