Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Top option-buttons now are css rounded. No more GIFs to simulate it. #845

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

pmourelle commented Feb 25, 2013

  • Top options buttons now are css rounded.
  • New PNG icons (for Add and GoTo).
  • Removed old GIFs simulating rounded borders.

pmourelle added some commits Feb 25, 2013

@pmourelle pmourelle - Top options buttons now are css rounded.
- New PNG icons (for Add and GoTo).
- Removed old GIFs simulating rounded borders.
3b60e04
@pmourelle pmourelle Removed non-used rule. Added webkit and moz prefixes for rounded butt…
…ons.
153ddbd
Owner

timgraham commented May 31, 2013

This is for ticket #19900.

@timgraham timgraham commented on the diff Jul 19, 2013

django/contrib/admin/static/admin/css/base.css
}
.object-tools a:link, .object-tools a:visited {
display: block;
float: left;
color: white;
- padding: .1em 14px .1em 8px;
- height: 14px;
- background: #999 url(../img/tool-right.gif) 100% 0 no-repeat;
+ padding: .2em 6px .2em 10px;
@timgraham

timgraham Jul 19, 2013

Owner

I changed this to "padding: .2em 10px;" otherwise the "History" button isn't symmetrical. I couldn't find any problems this caused, but let me know if I missed something.

@timgraham timgraham commented on the diff Jul 19, 2013

django/contrib/admin/static/admin/css/base.css
height: 16px;
}
-.object-tools li:hover {
- background: url(../img/tool-left_over.gif) 0 0 no-repeat;
+.object-tools a {
+ -webkit-border-radius: 15px;
@timgraham

timgraham Jul 19, 2013

Owner

Do you think we can drop the vendor prefixes? http://css-tricks.com/do-we-need-box-shadow-prefixes/ suggests it is probably safe.

@pmourelle

pmourelle Jul 19, 2013

Contributor

Sure. A squared corner is not a big deal (in the worst scenario), besides that major browsers will support it (if aren't already).

Owner

timgraham commented Jul 23, 2013

merged in fb052b5 - thanks!

@timgraham timgraham closed this Jul 23, 2013

Contributor

pmourelle commented Jul 23, 2013

Great Tim. Thanks! I had being too busy last days so I couldn't be more in the details. As soon as I get a time I'll check it.
Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment