New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #28199 -- Fixed Subquery generating unnecessary/invalid CAST. #8572

Merged
merged 1 commit into from May 30, 2017

Conversation

Projects
None yet
3 participants
@timgraham
Member

timgraham commented May 29, 2017

@timgraham

This comment has been minimized.

Show comment
Hide comment
@timgraham

timgraham May 29, 2017

Member

@charettes @schinckel -- any advice about things to try for a solution?

Member

timgraham commented May 29, 2017

@charettes @schinckel -- any advice about things to try for a solution?

@charettes

This comment has been minimized.

Show comment
Hide comment
@charettes

charettes May 29, 2017

Member

@timgraham it looks like it's caused by the call to unification_cast_sql in Subquery.as_sql(), what happens if you completely remove it?

Member

charettes commented May 29, 2017

@timgraham it looks like it's caused by the call to unification_cast_sql in Subquery.as_sql(), what happens if you completely remove it?

@timgraham timgraham changed the title from [WIP] Fixed #28199 -- Fixed Subquery __in generating unnecessary/invalid CAST. to Fixed #28199 -- Fixed Subquery generating unnecessary/invalid CAST. May 29, 2017

@charettes

@timgraham I'm pretty sure the inclusion of this code was a copy-paste leftover of the Case.as_sql() occurrence as it doesn't make much sense to be used here. Thanks for the tests!

@schinckel

This comment has been minimized.

Show comment
Hide comment
@schinckel

schinckel May 30, 2017

Contributor

Yeah, I don't recall whether there was a reason that was there. Probably more that I don't know exactly what it's supposed to do.

No failing tests elsewhere means it's either not needed, or needed for something that's not tested, I guess.

Contributor

schinckel commented May 30, 2017

Yeah, I don't recall whether there was a reason that was there. Probably more that I don't know exactly what it's supposed to do.

No failing tests elsewhere means it's either not needed, or needed for something that's not tested, I guess.

@timgraham timgraham merged commit f044955 into django:master May 30, 2017

17 checks passed

docs Build #16991 ended
Details
flake8 Build #17107 ended
Details
isort Build #17123 succeeded in 14 sec
Details
pull-requests-javascript Build #13490 ended
Details
pull-requests-trusty/database=mysql,label=trusty-pr,python=python3.4 Build #12779 ended
Details
pull-requests-trusty/database=mysql,label=trusty-pr,python=python3.6 Build #12779 ended
Details
pull-requests-trusty/database=mysql_gis,label=trusty-pr,python=python3.4 Build #12779 ended
Details
pull-requests-trusty/database=mysql_gis,label=trusty-pr,python=python3.6 Build #12779 ended
Details
pull-requests-trusty/database=postgis,label=trusty-pr,python=python3.4 Build #12779 ended
Details
pull-requests-trusty/database=postgis,label=trusty-pr,python=python3.6 Build #12779 ended
Details
pull-requests-trusty/database=postgres,label=trusty-pr,python=python3.4 Build #12779 ended
Details
pull-requests-trusty/database=postgres,label=trusty-pr,python=python3.6 Build #12779 ended
Details
pull-requests-trusty/database=spatialite,label=trusty-pr,python=python3.4 Build #12779 ended
Details
pull-requests-trusty/database=spatialite,label=trusty-pr,python=python3.6 Build #12779 ended
Details
pull-requests-trusty/database=sqlite3,label=trusty-pr,python=python3.4 Build #12779 ended
Details
pull-requests-trusty/database=sqlite3,label=trusty-pr,python=python3.6 Build #12779 ended
Details
pull-requests-windows/database=sqlite3,label=windows,python=Python35 Build #9092 ended
Details

@timgraham timgraham deleted the timgraham:28199 branch May 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment