Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fixed #19945 -- Fixed default User model Meta inheritance. #871

Merged
merged 1 commit into from

2 participants

@matiasb

Updated default User model Meta class to extend AbstractUser Meta
where translated verbose_name and verbose_name_plural are
defined.

@matiasb matiasb Fixed #19945 -- Fixed default User model Meta inheritance.
Updated default User model Meta class to extend AbstractUser Meta
where translated verbose_name and verbose_name_plural are
defined.
f39fead
@ramiro ramiro merged commit 03e4014 into django:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 1, 2013
  1. @matiasb

    Fixed #19945 -- Fixed default User model Meta inheritance.

    matiasb authored
    Updated default User model Meta class to extend AbstractUser Meta
    where translated verbose_name and verbose_name_plural are
    defined.
This page is out of date. Refresh to see the latest.
View
2  django/contrib/auth/models.py
@@ -461,7 +461,7 @@ class User(AbstractUser):
Username, password and email are required. Other fields are optional.
"""
- class Meta:
+ class Meta(AbstractUser.Meta):
swappable = 'AUTH_USER_MODEL'
View
11 django/contrib/auth/tests/basic.py
@@ -12,6 +12,7 @@
from django.core.management import call_command
from django.test import TestCase
from django.test.utils import override_settings
+from django.utils import translation
from django.utils.encoding import force_str
from django.utils.six import binary_type, PY3, StringIO
@@ -232,3 +233,13 @@ def test_swappable_user_nonexistent_model(self):
"The current user model must point to an installed model"
with self.assertRaises(ImproperlyConfigured):
get_user_model()
+
+ @skipIfCustomUser
+ def test_user_verbose_names_translatable(self):
+ "Default User model verbose names are translatable (#19945)"
+ with translation.override('en'):
+ self.assertEqual(User._meta.verbose_name, 'user')
+ self.assertEqual(User._meta.verbose_name_plural, 'users')
+ with translation.override('es'):
+ self.assertEqual(User._meta.verbose_name, 'usuario')
+ self.assertEqual(User._meta.verbose_name_plural, 'usuarios')
Something went wrong with that request. Please try again.