Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #19965 and #19211 - Tutorial is not written for Python 3.x #874

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@itsallvoodoo
Copy link

itsallvoodoo commented Mar 2, 2013

Both #19965 and #19211 are tutorial confusions that revolve around the fact the tutorial is written for 2.x and not 3.x. A note has been added at the beginning of the tutorial to reflect this.

@itsallvoodoo

This comment has been minimized.

Copy link
Author

itsallvoodoo commented Mar 2, 2013

I am not sure why git is including my old accepted pull request in this one. Is that normal behavior?

@claudep

This comment has been minimized.

Copy link
Member

claudep commented Mar 2, 2013

If both patches are in the same branch, yes, that's normal behaviour. I'd suggest to create a separate branch for each ticket you are going to propose a patch for.

@itsallvoodoo

This comment has been minimized.

Copy link
Author

itsallvoodoo commented Mar 2, 2013

Thank you for answering quickly. If you noticed, this is my second patch
ever, so getting used to github. I will branch separately from now on.
On Mar 2, 2013 1:44 PM, "Claude Paroz" notifications@github.com wrote:

If both patches are in the same branch, yes, that's normal behaviour. I'd
suggest to create a separate branch for each ticket you are going to
propose a patch for.


Reply to this email directly or view it on GitHubhttps://github.com//pull/874#issuecomment-14333023
.

@timgraham

This comment has been minimized.

Copy link
Member

timgraham commented Mar 12, 2013

merged, thank-you.

@timgraham timgraham closed this Mar 12, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.