New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #28749 -- Added subquery support for PostgreSQL’s ArrayField 'in' lookup #9300
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks straightforward to me, but please fix for flake8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add a release note to the 2.0.txt file
Hi @adamchainz , updated as suggested. As I understand, CI checks are being triggered automatically, right? |
Yes there might just be a queue though |
docs/releases/2.0.txt
Outdated
@@ -163,6 +163,9 @@ Minor features | |||
* :djadmin:`inspectdb` can now introspect ``JSONField`` and various | |||
``RangeField``\s (``django.contrib.postgres`` must be in ``INSTALLED_APPS``). | |||
|
|||
* The ``in`` lookup for `:class:`~django.contrib.postgres.fields.array.ArrayField` | |||
supports subqueries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ` before :class: is invalid
Add a period/full stop
tests/postgres_tests/test_array.py
Outdated
self.assertSequenceEqual( | ||
NullableIntegerArrayModel.objects.filter( | ||
field__in=IntegerArrayModel.objects.all().values_list( | ||
"field", flat=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is probably cleaner as one line
Commited, thanks
|
docs/releases/2.0.txt
Outdated
@@ -163,6 +163,9 @@ Minor features | |||
* :djadmin:`inspectdb` can now introspect ``JSONField`` and various | |||
``RangeField``\s (``django.contrib.postgres`` must be in ``INSTALLED_APPS``). | |||
|
|||
* The ``in`` lookup for :class:`~django.contrib.postgres.fields.array.ArrayField` | |||
supports subqueries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last thing I can see, you still need to add a period (.) at the end of the sentence
Still a couple CI failures doc:
Looks like this needs fixing, should be simple isort:
That newline you removed should be there |
@adamchainz CI says thing's legit now, thank you for your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
https://code.djangoproject.com/ticket/28749#ticket