Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #28749 -- Added subquery support for PostgreSQL’s ArrayField 'in' lookup #9300

Merged
merged 1 commit into from Nov 1, 2017

Conversation

@mpasternak
Copy link
Contributor

@mpasternak mpasternak commented Oct 27, 2017

Copy link
Member

@adamchainz adamchainz left a comment

Looks straightforward to me, but please fix for flake8

@adamchainz adamchainz changed the title Subquery support for PosgteSQL’s ArrayField’s „in” lookups Fixed #28749 -- Added subquery support for PostgreSQL’s ArrayField 'in' lookup Oct 30, 2017
Copy link
Member

@adamchainz adamchainz left a comment

Please also add a release note to the 2.0.txt file

@mpasternak
Copy link
Contributor Author

@mpasternak mpasternak commented Oct 30, 2017

Hi @adamchainz , updated as suggested. As I understand, CI checks are being triggered automatically, right?

@adamchainz
Copy link
Member

@adamchainz adamchainz commented Oct 30, 2017

Yes there might just be a queue though

@@ -163,6 +163,9 @@ Minor features
* :djadmin:`inspectdb` can now introspect ``JSONField`` and various
``RangeField``\s (``django.contrib.postgres`` must be in ``INSTALLED_APPS``).

* The ``in`` lookup for `:class:`~django.contrib.postgres.fields.array.ArrayField`
supports subqueries

This comment has been minimized.

@adamchainz

adamchainz Oct 30, 2017
Member

The ` before :class: is invalid
Add a period/full stop
📝🚀

self.assertSequenceEqual(
NullableIntegerArrayModel.objects.filter(
field__in=IntegerArrayModel.objects.all().values_list(
"field", flat=True)

This comment has been minimized.

@adamchainz

adamchainz Oct 30, 2017
Member

this is probably cleaner as one line

@mpasternak
Copy link
Contributor Author

@mpasternak mpasternak commented Oct 30, 2017

@@ -163,6 +163,9 @@ Minor features
* :djadmin:`inspectdb` can now introspect ``JSONField`` and various
``RangeField``\s (``django.contrib.postgres`` must be in ``INSTALLED_APPS``).

* The ``in`` lookup for :class:`~django.contrib.postgres.fields.array.ArrayField`
supports subqueries

This comment has been minimized.

@adamchainz

adamchainz Oct 30, 2017
Member

Last thing I can see, you still need to add a period (.) at the end of the sentence 😉

@adamchainz
Copy link
Member

@adamchainz adamchainz commented Oct 30, 2017

Still a couple CI failures

doc:

/home/jenkins/workspace/docs/docs/releases/2.0.txt:166: WARNING: py:class reference target not found: django.contrib.postgres.fields.array.ArrayField

Looks like this needs fixing, should be simple

isort:

+++ /home/jenkins/workspace/isort/tests/postgres_tests/test_array.py:after	2017-10-30 11:40:04.624306
@@ -11,6 +11,7 @@
 from django.test import TransactionTestCase, modify_settings, override_settings
 from django.test.utils import isolate_apps
 from django.utils import timezone
+
 from . import PostgreSQLTestCase, PostgreSQLWidgetTestCase
 from .models import (

That newline you removed should be there 😉

@mpasternak
Copy link
Contributor Author

@mpasternak mpasternak commented Oct 30, 2017

@adamchainz CI says thing's legit now, thank you for your suggestions.

Copy link
Member

@adamchainz adamchainz left a comment

Thanks for the contribution!

@timgraham timgraham force-pushed the mpasternak:master branch from 2aaafd5 to e554b72 Nov 1, 2017
@timgraham timgraham merged commit e554b72 into django:master Nov 1, 2017
17 checks passed
17 checks passed
docs Build #19962 ended
Details
flake8 Build #20076 ended
Details
isort Build #20093 succeeded in 21 sec
Details
pull-requests-javascript Build #16463 ended
Details
pull-requests-trusty/database=mysql,label=trusty-pr,python=python3.5 Build #15658 ended
Details
pull-requests-trusty/database=mysql,label=trusty-pr,python=python3.6 Build #15658 ended
Details
pull-requests-trusty/database=mysql_gis,label=trusty-pr,python=python3.5 Build #15658 ended
Details
pull-requests-trusty/database=mysql_gis,label=trusty-pr,python=python3.6 Build #15658 ended
Details
pull-requests-trusty/database=postgis,label=trusty-pr,python=python3.5 Build #15658 ended
Details
pull-requests-trusty/database=postgis,label=trusty-pr,python=python3.6 Build #15658 ended
Details
pull-requests-trusty/database=postgres,label=trusty-pr,python=python3.5 Build #15658 ended
Details
pull-requests-trusty/database=postgres,label=trusty-pr,python=python3.6 Build #15658 ended
Details
pull-requests-trusty/database=spatialite,label=trusty-pr,python=python3.5 Build #15658 ended
Details
pull-requests-trusty/database=spatialite,label=trusty-pr,python=python3.6 Build #15658 ended
Details
pull-requests-trusty/database=sqlite3,label=trusty-pr,python=python3.5 Build #15658 ended
Details
pull-requests-trusty/database=sqlite3,label=trusty-pr,python=python3.6 Build #15658 ended
Details
pull-requests-windows/database=sqlite3,label=windows,python=Python36 Build #11961 ended
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.