New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #18399 – Add a `for_concrete_model` kwarg to `ContentTypeManager.get_for_models?` #98

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@charettes
Member

charettes commented May 29, 2012

Is is now possible to retrive ContentType instances associated with proxy models using those methods.

Fixed #18399 – Add a `for_concrete_model` kwarg to
`ContentTypeManager.get_for_models?`

Is is now possible to retrive `ContentType` instances associated
with proxy models using those methods.
@akaariai

This comment has been minimized.

Show comment
Hide comment
@akaariai

akaariai Jun 1, 2012

Member

As said in the ticket I think this change makes sense - there are situations where you want the proxy model contenttype, and there are situations when you want the concrete model contenttype. However, the kwarg of "for_concrete_model" doesn't feel right. Any ideas for improving that?

Member

akaariai commented Jun 1, 2012

As said in the ticket I think this change makes sense - there are situations where you want the proxy model contenttype, and there are situations when you want the concrete model contenttype. However, the kwarg of "for_concrete_model" doesn't feel right. Any ideas for improving that?

@charettes

This comment has been minimized.

Show comment
Hide comment
@charettes

charettes Jun 8, 2012

Member

Fixed by b6d533a

Member

charettes commented Jun 8, 2012

Fixed by b6d533a

@charettes charettes closed this Jun 8, 2012

@akaariai

This comment has been minimized.

Show comment
Hide comment
@akaariai

akaariai Jun 8, 2012

Member

Pulled in manually with minor editing in commit b6d533a. I resolved a merge conflict in releases/1.5.txt, reworded the commit message and cleaned up some whitespace errors.

Member

akaariai commented Jun 8, 2012

Pulled in manually with minor editing in commit b6d533a. I resolved a merge conflict in releases/1.5.txt, reworded the commit message and cleaned up some whitespace errors.

@charettes charettes deleted the charettes:ticket-18399-add-for_concrete_model-kwarg-to-CT.get_for_models branch Jul 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment