Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed #19252 -- Added support for wheel packages. #995

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Owner

apollo13 commented Apr 5, 2013

Packages have to be created using pip wheel . (requires pip 1.4, wheel and
distribute).

Member

ptone commented Apr 6, 2013

👍 with wheel installed - isn't there a way to have the bdist generated and sent to pypi directly without using pip?

Also, do we need to add some instructions to our "how to release django doc"?

Owner

apollo13 commented Apr 6, 2013

To make the first work we would need to use distribute in setup.py which Jannis was against. Docs need an update yes.

@jezdez jezdez and 1 other commented on an outdated diff Apr 23, 2013

extras/Makefile
@@ -0,0 +1,9 @@
+all: sdist bdist_wheel
+
+sdist:
+ python setup.py sdist
+
+bdist_wheel:
+ python -c "import setuptools;__file__='setup.py';exec(compile(open(__file__).read().replace('\\r\\n', '\\n'), __file__, 'exec'))" bdist_wheel -d dist
@jezdez

jezdez Apr 23, 2013

Owner

Why is the -d dist needed? I thought dist is the default?

@apollo13

apollo13 Apr 23, 2013

Owner

On Tue, Apr 23, 2013 at 9:32 PM, Jannis Leidel notifications@github.com wrote:

Why is the -d dist needed? I thought dist is the default?

Good point, I removed it now, I think with "pip wheel" it ended up in
wheelhouse or so, but bdist_wheel indeed puts it into dist/

@jezdez jezdez commented on the diff Apr 23, 2013

@@ -55,15 +36,22 @@ def fullsplit(path, result=None):
return result
return fullsplit(head, [tail] + result)
-# Tell distutils not to put the data_files in platform-specific installation
-# locations. See here for an explanation:
-# http://groups.google.com/group/comp.lang.python/browse_thread/thread/35ec7b2fed36eaec/2105ee4d9e8042cb
-for scheme in INSTALL_SCHEMES.values():
- scheme['data'] = scheme['purelib']
+
+EXCLUDE_FROM_PACKAGES = ['django.conf.project_template',
@jezdez

jezdez Apr 23, 2013

Owner

Let's wrap this line?

@apollo13

apollo13 Apr 23, 2013

Owner

Let's wrap this line?

Wrap how exactly? (I'll happily do it, I just have no idea how you
want it to be wrapped)

@jezdez

jezdez May 1, 2013

Owner

Like so:

EXCLUDE_FROM_PACKAGES = ['django.conf.project_template',
                         'django.conf.app_template',
                         'django.bin']

@jezdez jezdez closed this May 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment