Skip to content

Fixed #20003 -- Added user:password support to URLValidator. #998

Closed
wants to merge 9 commits into from

8 participants

@matiasb
matiasb commented Apr 6, 2013

No description provided.

Alex Gaynor and others added some commits Apr 4, 2013
Alex Gaynor Fixed a line that was overindented. 1aca9d9
@charettes charettes Merge pull request #993 from almostabc/template-include-docs-update
Removed a trailing space in the template builtins docs.
d7fa802
@aaugustin aaugustin Removed LocaleMiddleware from settings template.
It was added in 3f1c7b7.

Single language sites should always be translated in LANGUAGE_CODE,
regardless of the browser's Accept-Language. Having LocaleMiddleware
enabled can result in having some parts, like the admin, translated
in an unexpected language, typically if someone browses a non-English
website on a system set up in English. Since most websites won't be
translated in multiple languages — especially at the time they're
created — it's better not to enable LocaleMiddleware by default.

Thanks Ramiro for the feedback.
2322906
@claudep claudep Added release note about percent literals in cursor.execute
Thanks Aymeric Augustin for noticing the omission and Tim Graham
for the text review.
Fixes #9055 (again).
975c5af
@ptone ptone Fixed #20114 -- support custom project login_url in tests
Thanks to Matias Bordese for the patch
a49e7dd
@charettes charettes Fixed #20207 -- Handle ManyToManyField with a unicode name correctly. 216580e
@andrewjesaitis andrewjesaitis Explicitly removes dismissClock
Uses the removeEvent function in core.js to remove the function from
the document click event.
Refs #4045.
4509a1b
@andrewjesaitis andrewjesaitis Explicitly removes dismissCalendar
Uses the removeEvent function in core.js to remove the dismissCalendar
function from the document click event.
Fixes #4045.
5ab66de
@matiasb matiasb Fixed #20003 -- Added user:password support to URLValidator. 2407690
@apollo13
Django member

The regex looks a bit over engineered to me, can't we somehow get away with an easier one? Like using [^:] for the username.

@matiasb
matiasb commented May 18, 2013

Right, just tried to match the link referenced in the ticket. So just let me know and I can simplify this to be much simpler (of course it won't be handling all the restrictions).

@timgraham
Django member

Closing as the PR needs improvement as noted above.

@timgraham timgraham closed this Feb 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.