Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Osm #39

Closed
wants to merge 7 commits into
from

Conversation

Projects
None yet
2 participants

First shot for #37.
As we discussed, lets finish and merge each step before starting the next one.
I think we have now an "isofeatured" branch using Leaflet and OSM tiles (we may chose other tiles by the way).
I open the PR to discuss the changes here.
Let me know when you have time to review :)

Collaborator

brutasse commented Sep 24, 2012

Looks great! I love the geolocation stuff on the signup page.

It's funny that the scroll wheel is disabled, I'd usually expect it to work. What do you think about adding it back?

My major concert is about SSL: people.djangoproject.com is full-SSL (except geonames for the signup page but we should proxy the API to avoid mixed content warnings). Some files are served over HTTP:

  • the leaflet JS and CSS code
  • the map tiles

Embedding the leaflet code with our current way to deal with static assets is easy, however it doesn't seem like thunderforest supports HTTPS. Do you know a provider that works with SSL sites?

Collaborator

brutasse commented Sep 24, 2012

MapBox SSL private beta:

https://docs.google.com/spreadsheet/viewform?formkey=dHI1TUNQdGdtRGozQWlUMXgzWkVvemc6MA

They have some very nice-looking themes. We'd probably need a Standard plan though, $49/month…

It's funny that the scroll wheel is disabled, I'd usually expect it to work. What do you think about adding it back?

Humm, the fact is that we have a page that mix HTML content and a map, and on top of that this map is full width: this means that when you will use your wheel to scroll down in the page, when your mouse will pass over the map you will activate the zoom of the map, and so stop scrolling down the page. So I doubt it will be a good ergonomic point. But I'm not opposed ;). Lets say I'm -0.
Maybe we can use a fullscreen plugin (http://brunob.github.com/leaflet.fullscreen/) to give users a better way to enjoy the map per se?

About SSL from OSM servers: https://help.openstreetmap.org/questions/10920/how-to-embed-a-map-in-my-https-site => TL;DR: not the job of OSM servers

@yohanboniface yohanboniface cf brutasse#37 - Serve locally the leaflet statics
Goals:
- serve them in HTTPS
- minify them with our solutions
5cecad0

@brutasse brutasse referenced this pull request May 1, 2013

Merged

OSM #45

2 of 3 tasks complete
Collaborator

brutasse commented May 1, 2013

New pull request up-to-date with current master: #45. Let's both work on this branch if you don't mind. Closing this, I've summarized the remaining issues in the other PR. Don't hesitate if you see something else :)

@brutasse brutasse closed this May 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment