Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Disable resolv-replace for ruby 1.9.3 #13

Merged
merged 1 commit into from

2 participants

@j15e

@see conflict with spork sporkrb/spork#133

Not sure this should be merged as is, maybe you should investigate further what is the issue with resolv-replace rather than disabling it completely for ruby 1.9.3.

I see this is made for performance purpose, but I think overwriting standard libs should not be made without consent from the gem user (maybe you could a configuration option for this).

@djberg96
Owner

I haven't been keeping up. Have resolve.rb and resolve-replace.rb been merged in 1.9.3+ ?

I think yes, from 1.9.3 documentation :

 Resolv is a thread-aware DNS resolver library written in Ruby. Resolv can handle multiple DNS requests concurrently without blocking the entire ruby interpreter.

http://www.ruby-doc.org/stdlib-1.9.3/libdoc/resolv/rdoc/Resolv.html

@j15e

Bump @djberg96, can you update me on this issue?

@djberg96
Owner

Sorry I've been slow on this. I want to split out the ldap portion into its own lib, so that's been the holdup.

@djberg96 djberg96 merged commit 8565e75 into djberg96:master
@j15e

Awesome, thanks for the merge & follow up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 8, 2012
  1. @j15e

    Disable resolv-replace for ruby 1.9.3

    j15e authored
    @see issue with spork sporkrb/spork#133
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  lib/net/ping/http.rb
View
2  lib/net/ping/http.rb
@@ -5,7 +5,7 @@
# Force non-blocking Socket.getaddrinfo on Unix systems. Do not use on
# Windows because it (ironically) causes blocking problems.
-unless File::ALT_SEPARATOR
+unless File::ALT_SEPARATOR or RUBY_VERSION >= "1.9.3"
require 'resolv-replace'
end
Something went wrong with that request. Please try again.