add support for proxies to Net::Ping::HTTP #15

Merged
merged 7 commits into from Jan 28, 2013

Conversation

Projects
None yet
3 participants
Contributor

olbrich commented Jan 24, 2013

It now gets proxy information from the http_proxy, https_proxy, and no_proxy environment variables and uses that when making requests. Fixes #14

Kevin Olbrich added some commits Jan 24, 2013

Collaborator

lzap commented Jan 25, 2013

Will the test work also without internet connection? I guess so. Please confirm.

Contributor

olbrich commented Jan 26, 2013

The new tests pass without an internet connection. They pretty much use FakeWeb for everything.

djberg96 added a commit that referenced this pull request Jan 28, 2013

Merge pull request #15 from 6fusion/master
add support for proxies to Net::Ping::HTTP

@djberg96 djberg96 merged commit 54d8fb4 into djberg96:master Jan 28, 2013

FYI, it appears that proxy information is now used by default for Net::HTTP::New in Ruby 2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment