Add missing rake development dependency #17

Merged
merged 1 commit into from Jul 17, 2013

Conversation

Projects
None yet
2 participants
Contributor

j15e commented May 31, 2013

Required for tests, otherwise it doesn't work out of the box.

Huh? Isn't rake stdlib now? Or is this so you can ensure the latest and greatest? I kinda worry that this is a slippery slope.

Owner

j15e replied May 31, 2013

Yep rake is part of the std-lib but using what I think is a typical ruby/bundler setup you'll get the following error when running rake for tests :

gems/ruby-2.0.0-p195@global/gems/bundler-1.3.5/lib/bundler/rubygems_integration.rb:214:in `block in replace_gem': rake is not part of the bundle. Add it to Gemfile. (Gem::LoadError)
    from gems/ruby-2.0.0-p195/bin/rake:22:in `<main>'
    from gems/ruby-2.0.0-p195/bin/ruby_noexec_wrapper:14:in `eval'
    from gems/ruby-2.0.0-p195/bin/ruby_noexec_wrapper:14:in `<main>'

I know you seems to try to keep this gem to the minimal dependencies, but I think it would help any new contributor not having to deal with this (and it's a development dependency so it isn't adding to runtime dependencies).

There might be a better way to work around this, the other solution being to uninstall previously bundled rake as described here (but this is even more complicated) :

http://stackoverflow.com/questions/12966564/cant-make-calls-to-heroku-cli-from-within-a-rake-task-without-the-heroku-gem-in

In short, I think this would help contributors, but you may disagree, I won't be offended ✌️

djberg96 merged commit 6171ab9 into djberg96:master Jul 17, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment