Improve http ping response #27

Merged
merged 2 commits into from Jan 10, 2014

Conversation

Projects
None yet
2 participants
Contributor

aortbals commented Jan 9, 2014

This pull request does two things:

  1. It is useful to store the http status code returned by a server when it is a client error (4XX) or server error (5XX). This can give insight into why the ping failed.
  2. In the above situation (say a server returns a 502), then we should also store this in the exception attribute.

Tests added.

djberg96 added a commit that referenced this pull request Jan 10, 2014

Merge pull request #27 from aortbals/master
Improve http ping response

@djberg96 djberg96 merged commit d7ccae6 into djberg96:master Jan 10, 2014

Owner

djberg96 commented Jan 10, 2014

Looks good, thanks!

Contributor

aortbals commented Jan 10, 2014

Thanks for merging 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment