Adding LDAP protocol ping support #4

Merged
merged 5 commits into from May 4, 2011

Projects

None yet

2 participants

@tardate
Contributor
tardate commented Apr 29, 2011

Hi Daniel, I've added an ldap module with tests to net-ping. It helps go beyond simple tcp tests and actually talk LDAP to bind/verify. I've also removed a deprecated gemspec element but left the version and other details as before.

  • LDAP protocol-specific ping
  • added Gemfile for bundler
  • removed deprecated gemspec elements
tardate added some commits Apr 29, 2011
@tardate tardate Added initial Net::Ping::LDAP implementation
* LDAP protocol-specific ping
* added Gemfile for bundler
* removed deprecated gemspec elements
0f62d00
@tardate tardate Add ping/ldap include to main project 84dee6b
@djberg96

Looks pretty good, thanks. The only mistake I noticed was the documentation for intialize.

I'll pull after you fix the docs. Also, I don't want Gemfiles in my project.

@tardate tardate Update Ping::LDAP documentation
* removed Gemfile from the project
01f8ac7
Contributor
tardate commented Apr 30, 2011

Hi Daniel, here you go .. updated the docs and removed the Gemfile. I think you should see the pull request now includes updated commit range.
Cheers, and thanks for the library .. have you really been maintaining this since 2002? Impressive!

tardate added some commits May 4, 2011
@tardate tardate bad ping after good should unset duration
* in 1.4.1, a bad ping after a good ping will leave @duration set at the result of the good ping. I'd expect it to unset @duration .. this commit includes a test and a fix for this behaviour
4c18e5b
@tardate tardate Add Ping::LDAP test for bad ping after good 965031c
@djberg96 djberg96 merged commit 965031c into djberg96:master May 4, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment