Bad ping after good should unset duration? #5

Closed
wants to merge 2 commits into
from

Projects

None yet

2 participants

@tardate
Contributor
tardate commented May 4, 2011

In 1.4.1, it seems a bad ping after a good ping will leave @duration set at the result of the good ping.

I'd expect it to unset @duration .. these two commits include tests (I've just added for external and LDAP classes so far) and a fix for this behaviour so that a bad ping will cause duration to be unset.

NB: Daniel, note that the base commit for this patch is my prior pull request.

tardate added some commits May 4, 2011
@tardate tardate bad ping after good should unset duration
* in 1.4.1, a bad ping after a good ping will leave @duration set at the result of the good ping. I'd expect it to unset @duration .. this commit includes a test and a fix for this behaviour
4c18e5b
@tardate tardate Add Ping::LDAP test for bad ping after good 965031c
@djberg96
Owner
djberg96 commented May 4, 2011

Merged and released. Thanks!

@djberg96 djberg96 closed this May 4, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment