Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flags method to get / set current task flags #9

Closed
wants to merge 1 commit into from

Conversation

Iristyle
Copy link

@Iristyle Iristyle commented Jul 3, 2014

  • Previous versions of this gem exposed the flags. This change
    introduces backwards compatibility with previous versions of the gem

def flags
raise Error, 'No currently active task' if @task.nil?

require 'pry'; binding.pry

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Iristyle extra debug line

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joshcooper!

@ferventcoder
Copy link

@djberg96 This would be awesome to get back in. It's the last thing holding up our removal of the windows-pr gem. Thoughts on this?

@djberg96
Copy link
Collaborator

djberg96 commented Jul 3, 2014

Eh, why do you need this method? And I'm unlikely to add pry as a dependency.

@ferventcoder
Copy link

The pry bits got removed :) - that was a mistake there. Artifact of debugging.

@joshcooper
Copy link

Hi @djberg96, about the flags methods, we need that to determine if a task has been enabled or disabled (it's disabled if the TASK_FLAG_DISABLED bit is set).

 - Previous versions of this gem exposed the flags.  This change
   introduces backwards compatibility with previous versions of the gem
@Iristyle
Copy link
Author

Iristyle commented Jul 3, 2014

Hold off on merging this... discovered that it might not quite be enough.

Our tests are mocked, and may have hidden an error in this PR. Will follow up in a bit.

Thanks!

@Iristyle
Copy link
Author

Iristyle commented Jul 7, 2014

This actually doesn't make any sense... closed in favor of a new PR

@Iristyle Iristyle closed this Jul 7, 2014
@djberg96
Copy link
Collaborator

djberg96 commented Jul 7, 2014

I was wondering about this. ;)

@Iristyle
Copy link
Author

Iristyle commented Jul 7, 2014

Wonder no more ;0

Thought we had a quick fix on top of your 0.3.x code to add back support for how we were determining Enabled over tasks in Puppet.

However, we've since realized that with the change to use the Scheduler.Service class, we can't use the 0.3.x branch / gems as Puppet supports Windows 2003.

I'm doing the work now on top of the 0.2.2 branch so that it's FFI and x64 friendly.

Would you have any interest in accepting patches and releasing a new 0.2.3 gem in that series?

Thanks again for all the work on these gems.

@djberg96
Copy link
Collaborator

djberg96 commented Jul 7, 2014

"Would you have any interest in accepting patches and releasing a new 0.2.3 gem in that series?"

Money talks. :)

@Iristyle Iristyle deleted the 0.3.0-missing-flags branch July 15, 2014 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants