New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flags method to get / set current task flags #9
Conversation
def flags | ||
raise Error, 'No currently active task' if @task.nil? | ||
|
||
require 'pry'; binding.pry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Iristyle extra debug line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @joshcooper!
@djberg96 This would be awesome to get back in. It's the last thing holding up our removal of the windows-pr gem. Thoughts on this? |
Eh, why do you need this method? And I'm unlikely to add pry as a dependency. |
The pry bits got removed :) - that was a mistake there. Artifact of debugging. |
Hi @djberg96, about the |
- Previous versions of this gem exposed the flags. This change introduces backwards compatibility with previous versions of the gem
Hold off on merging this... discovered that it might not quite be enough. Our tests are mocked, and may have hidden an error in this PR. Will follow up in a bit. Thanks! |
This actually doesn't make any sense... closed in favor of a new PR |
I was wondering about this. ;) |
Wonder no more ;0 Thought we had a quick fix on top of your However, we've since realized that with the change to use the I'm doing the work now on top of the Would you have any interest in accepting patches and releasing a new Thanks again for all the work on these gems. |
"Would you have any interest in accepting patches and releasing a new 0.2.3 gem in that series?" Money talks. :) |
introduces backwards compatibility with previous versions of the gem