Change notify_waiters to notify_one on broken conns - #225
Merged
Conversation
When a connection is dropped but broken, we notify all waiting get requests that they should try again. This is done in order to ensure we have enough pending connections to serve all in- flight gets. Because only a single connection dropped however, we only need to notify one waiter to refresh, not all of them.
Closed
djc
approved these changes
Oct 15, 2024
magec
pushed a commit
to OneSignal/pgcat
that referenced
this pull request
Oct 23, 2024
To get djc/bb8#186 and djc/bb8#189 which fix potential deadlocks (djc/bb8#154). Also, this (djc/bb8#225) was needed to prevent a connection leak which was conveniently spotted in our integration tests.
drdrsh
pushed a commit
to postgresml/pgcat
that referenced
this pull request
Oct 28, 2024
* Update bb8 to 0.8.6 To get djc/bb8#186 and djc/bb8#189 which fix potential deadlocks (djc/bb8#154). Also, this (djc/bb8#225) was needed to prevent a connection leak which was conveniently spotted in our integration tests. * Ignore ./.bundle (created by dev console) --------- Co-authored-by: Jose Fernandez (magec) <joseferper@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a connection is dropped but broken, we notify all waiting get requests that they should try again. This is done in order to ensure we have enough pending connections to serve all in- flight gets. Because only a single connection dropped however, we only need to notify one waiter to refresh, not all of them.
I'm moving this from #223 just to prove it doesn't break any tests.