-
-
Notifications
You must be signed in to change notification settings - Fork 509
H3 interop fixes #570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
H3 interop fixes #570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
LGTM (pending test fixes). |
00c71f3 to
fa60c79
Compare
657e0f5 to
ad7f055
Compare
ad7f055 to
2648360
Compare
Pull Request Test Coverage Report for Build 0fc01a5a2dcbe3eac675fdd5a7b271b848b47237-PR-570
💛 - Coveralls |
Contributor
Author
|
I think this is ready now. |
djc
reviewed
Dec 30, 2019
2648360 to
a84bae1
Compare
djc
approved these changes
Dec 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes needed to get better results at interop, along with some tooling and tracing.