Skip to content

Opaque config structs #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
djc merged 5 commits into from
Jan 13, 2020
Merged

Opaque config structs #583

djc merged 5 commits into from
Jan 13, 2020

Conversation

@Ralith
Copy link
Collaborator

@Ralith Ralith commented Jan 6, 2020 •
edited
Loading

Fixes #444.

@Ralith Ralith force-pushed the opaque-config branch 3 times, most recently from 3a03543 to be662c8 Compare January 6, 2020 07:58
djc
djc reviewed Jan 6, 2020
View reviewed changes
djc
djc reviewed Jan 6, 2020
View reviewed changes
@djc
Copy link
Member

djc commented Jan 7, 2020

I'm +1 on this direction!

@Ralith Ralith marked this pull request as ready for review January 8, 2020 03:33
@Ralith
Copy link
Collaborator Author

Ralith commented Jan 8, 2020

I think that accounts for all the most obnoxious parts.

@github-actions
Copy link

github-actions bot commented Jan 8, 2020

Pull Request Test Coverage Report for Build 2893332c99e6b4053b05dd8f64f1531be74b6915-PR-583

  • 68 of 176 (38.64%) changed or added relevant lines in 7 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.4%) to 70.204%
Changes Missing Coverage Covered Lines Changed/Added Lines %
quinn-proto/src/crypto/ring.rs 0 1 0.0%
quinn-proto/src/connection.rs 15 18 83.33%
quinn-proto/src/shared.rs 30 134 22.39%
Files with Coverage Reduction New Missed Lines %
quinn-proto/src/endpoint.rs 1 81.26%
quinn-proto/src/shared.rs 1 36.67%
Totals Coverage Status
Change from base Build 29dfcab51f5000c1f553fb5b8a97a9a0758c9b1b: -0.4%
Covered Lines: 9931
Relevant Lines: 14146
💛 - Coveralls

@Ralith
Copy link
Collaborator Author

Ralith commented Jan 8, 2020

I feel like coveralls shouldn't be failing the CI here.

djc
djc previously approved these changes Jan 12, 2020
View reviewed changes
@djc
Copy link
Member

djc commented Jan 12, 2020

This needs rebasing.

@Ralith
Copy link
Collaborator Author

Ralith commented Jan 12, 2020

Rebased.

@djc djc merged commit aa13434 into master Jan 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the opaque-config branch January 13, 2020 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@djc djc djc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Consider making the config structs opaque

3 participants

@Ralith @djc