Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workaround for two consecutive spaces in response #25

Merged
merged 1 commit into from Aug 24, 2018

Conversation

@vandenoever
Copy link
Contributor

@vandenoever vandenoever commented Aug 24, 2018

This is an issue with the DavMail server.

@djc
Copy link
Owner

@djc djc commented Aug 24, 2018

The change looks good! You committed this against 0.4.1, can you rebase on top of master please?

@vandenoever vandenoever force-pushed the vandenoever:fix_spaces branch from 444feef to b4232c9 Aug 24, 2018
@vandenoever
Copy link
Contributor Author

@vandenoever vandenoever commented Aug 24, 2018

Done

@djc
Copy link
Owner

@djc djc commented Aug 24, 2018

Your test fails, I guess you're using nom 3 stuff instead of nom 4? Can you fix that up?

@vandenoever
Copy link
Contributor Author

@vandenoever vandenoever commented Aug 24, 2018

Right. I'll do so later today. I assumed it would stay the same.

@djc
Copy link
Owner

@djc djc commented Aug 24, 2018

Here's an example fix from the nom 3 -> 4 conversion:

c7ed8c8#diff-c7845db764eb3d1f65eee26827f7fcc5R773

This is an issue with the DavMail server.
@vandenoever vandenoever force-pushed the vandenoever:fix_spaces branch from b4232c9 to ce20db3 Aug 24, 2018
@vandenoever
Copy link
Contributor Author

@vandenoever vandenoever commented Aug 24, 2018

It seems to work now, locally and in the CI.

@djc djc merged commit 5c5a994 into djc:master Aug 24, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@djc
Copy link
Owner

@djc djc commented Aug 24, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.