Add workaround for two consecutive spaces in response #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The change looks good! You committed this against 0.4.1, can you rebase on top of master please? |
vandenoever
force-pushed
the
fix_spaces
branch
from
444feef
to
b4232c9
Compare
|
Done |
|
Your test fails, I guess you're using nom 3 stuff instead of nom 4? Can you fix that up? |
|
Right. I'll do so later today. I assumed it would stay the same. |
|
Here's an example fix from the nom 3 -> 4 conversion: |
This is an issue with the DavMail server.
vandenoever
force-pushed
the
fix_spaces
branch
from
b4232c9
to
ce20db3
Compare
|
It seems to work now, locally and in the CI. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This is an issue with the DavMail server.