Better dialog to save attachments. #326

Merged
merged 1 commit into from Dec 19, 2013

Projects

None yet

2 participants

Contributor

This commit replaces the call to read-directory-name' by a call toread-file-name' when asking the user about the target location for
saving an attachment. This new dialog is better suited because:

1/ the user is currently saving a file, not a directory: he might want
to complete over existing files (e.g., to replace an existing file
with a new one just received).

2/ the current dialog was asking for a directory but then, if the user
enters a directory, mu4e proposes him to "override" the directory
with a file. This is not going to work obviously. In the new dialog,
it is also possible to enter a directory name instead of a file name.
In this case, a new file is created under the chosen directory name.

@DamienCassou DamienCassou Better dialog to save attachments.
This commit replaces the call to `read-directory-name' by a call to
`read-file-name' when asking the user about the target location for
saving an attachment. This new dialog is better suited because:

1/ the user is currently saving a file, not a directory: he might want
   to complete over existing files (e.g., to replace an existing file
   with a new one just received).

2/ the current dialog was asking for a directory but then, if the user
   enters a directory, mu4e proposes him to "override" the directory
   with a file. This is not going to work obviously. In the new dialog,
   it is also possible to enter a directory name instead of a file name.
   In this case, a new file is created under the chosen directory name.
6e790ba
@djcb djcb merged commit f859c44 into djcb:master Dec 19, 2013
Owner
djcb commented Dec 19, 2013

merged, thanks!

@DamienCassou DamienCassou deleted the DamienCassou:dialog-to-save-attachments branch Dec 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment