Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mu4e: Only switch context when really necessary. #744

Closed
wants to merge 1 commit into from
Closed

mu4e: Only switch context when really necessary. #744

wants to merge 1 commit into from

Conversation

magthe
Copy link
Contributor

@magthe magthe commented Dec 20, 2015

It's unnecessary to call the leave and enter functions when not really switching context.

This will allow use of destructive functions (.e.g. clearing of caches) in the leave function.

Signed-off-by: Magnus Therning <magnus@therning.org>
@magthe
Copy link
Contributor Author

magthe commented Dec 21, 2015

I'm guessing this can be closed with 60192a6, right?

@djcb
Copy link
Owner

djcb commented Dec 21, 2015

Ah, thanks for this, appreciated.

I solved the same in a slightly different way though (hope you're not offended!), defaulting to not doing anything when new context is the same as the current one, but allow to force it, using a prefix-argument.

Note that this slightly changes mu4e-context-switch interface.

@magthe
Copy link
Contributor Author

magthe commented Dec 21, 2015

Your way is better :)

@djcb
Copy link
Owner

djcb commented Dec 23, 2015

Thanks :-) There some customization now, using mu4e-context-policy and mu4e-compose-context-policy.

@djcb djcb closed this Dec 23, 2015
@magthe
Copy link
Contributor Author

magthe commented Dec 24, 2015

I had a look at those... I can't seem to get things to work the way I want, I'm always asked about what context I want. I'll have to look into it a bit more before raising any issue for it though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants