"Leaky" log buffer #16

Merged
merged 4 commits into from Apr 1, 2012

Conversation

Projects
None yet
2 participants
Contributor

tkf commented Mar 28, 2012

Sometimes I want to lookback some unimportant messages but it is too late to alter sauron-min-priority because the messages are gone.

This change introduces _*Sauron Log* buffer which shows all messages added by sauron-add-event. This buffer act like *Messages* buffer; sauron automatically removes old messages when the total number exceeds sauron-log-buffer-max-lines.

Only the last commit changes the functionality. First three commits are refactoring to prepare the change and I think they does not later sauron's function.

tkf added some commits Mar 28, 2012

@tkf tkf switched when and let* clauses in sauron-add-event d183f18
@tkf tkf refactored sr-create-buffer-maybe
Now, it does not alter any global variables.
750ee2e
@tkf tkf moved sr-buffer-name to suppress compiler warning 47a5124
@tkf tkf added leaky log buffer functionality
This change introduces "_*Sauron Log*" buffer which stores all messages
shows by sauron-add-event.  This buffer act like "*Messages*" buffer;
sauron automatically removes old messages when the total number exceeds
sauron-log-buffer-max-lines.
5b53b71
Owner

djcb commented Mar 30, 2012

Thanks! Looks like a good idea, I'll review it this weekend.

--Dirk.

Contributor

tkf commented Mar 30, 2012

Great!

@djcb djcb added a commit that referenced this pull request Apr 1, 2012

@djcb djcb Merge pull request #16 from tkf/log-buffer
* refactoring + added *Sauron Log* buffer which logs all sauron events, for debugging. Contributed by Takafumi Arakaki ("TKF").
7c461e6

@djcb djcb merged commit 7c461e6 into djcb:master Apr 1, 2012

Owner

djcb commented Apr 1, 2012

Okay, merged. Thanks for your contribution!

Contributor

tkf commented Apr 1, 2012

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment