Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakpoint sound fires on Step while debugging #2

Closed
Grifplex opened this issue Nov 20, 2019 · 3 comments
Closed

Breakpoint sound fires on Step while debugging #2

Grifplex opened this issue Nov 20, 2019 · 3 comments
Assignees
Labels

Comments

@Grifplex
Copy link

@Grifplex Grifplex commented Nov 20, 2019

I thank you for this extension to fill in audio clues where vsDingExtension stopped support at VS 2015.
The only thing you extensions falls short is that the Breakpoint sound fires not only when a breakpoint is hit but also when a step action completes. This gets old quickly when rapidly stepping through code. Is there a way to filter out simple steps and only play the sound after running?
Thanks, Nick.

@djfoxer

This comment has been minimized.

Copy link
Owner

@djfoxer djfoxer commented Nov 20, 2019

Thank you for your feedback. I think your suggestion is crucial in that case I will investigate it and try to figure out how to fix it. Also that linked project looks interesting, maybe I will be able to implement something new from that repo.

@djfoxer djfoxer added the enhancement label Nov 20, 2019
@djfoxer

This comment has been minimized.

Copy link
Owner

@djfoxer djfoxer commented Nov 20, 2019

Ok, I think I have found the solution: 901544c#diff-41794c332f2ee023241c5e8c910a676a Just need more testing

@djfoxer djfoxer added this to the 0.2.2 - small improvements milestone Nov 20, 2019
@djfoxer djfoxer self-assigned this Nov 20, 2019
@djfoxer

This comment has been minimized.

Copy link
Owner

@djfoxer djfoxer commented Nov 21, 2019

Done (PR: #3) you can check it by downloading new version 0.2.2

@djfoxer djfoxer closed this Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.