Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection changed callback does not respect input or output as device type #50

Closed
achronop opened this issue Oct 3, 2018 · 4 comments
Assignees

Comments

@achronop
Copy link

achronop commented Oct 3, 2018

Registering a callback for input or output collection change is supported by Linux backends (both C and rust). The following code should be supported:

  int rv = cubeb_register_device_collection_changed(GetCubebContext(),
       static_cast<cubeb_device_type>(CUBEB_DEVICE_TYPE_INPUT | CUBEB_DEVICE_TYPE_OUTPUT),
       &mozilla::CubebDeviceEnumerator::AudioDeviceListChanged_s, this);

With cubeb remote on, the collection change callback is not triggered on plug or unplug. However, the method returns CUBEB_OK and does not give the opportunity to the client to workaround the missing callback.

@kinetiknz kinetiknz self-assigned this Oct 11, 2018
@kinetiknz
Copy link
Contributor

Note to self: cubeb_stream_register_device_changed_callback is also unimplemented.

@kinetiknz
Copy link
Contributor

Note to self: this needs to be based on the changes made in BMO 1498242

@kinetiknz
Copy link
Contributor

9600391 merged Alex's patch that at least fixed the wrong error code. Actual implementation of the callbacks coming soon.

@kinetiknz
Copy link
Contributor

Closed via #62.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants