Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fab archer monitor broken #104

Closed
velocirobbie opened this issue May 24, 2019 · 10 comments

Comments

@velocirobbie
Copy link
Collaborator

commented May 24, 2019

Can't check queue status on archer. I don't understand how this function is supposed to work sorry.

fab archer monitor

Traceback (most recent call last): File "/usr/local/lib/python3.7/site-packages/fabric/main.py", line 763, in main *args, **kwargs File "/usr/local/lib/python3.7/site-packages/fabric/tasks.py", line 387, in execute multiprocessing File "/usr/local/lib/python3.7/site-packages/fabric/tasks.py", line 277, in _execute return task.run(*args, **kwargs) File "/usr/local/lib/python3.7/site-packages/fabric/tasks.py", line 174, in run return self.wrapped(*args, **kwargs) File "/Users/robertsinclair/codes/FabSim3/base/manage_remote_job.py", line 339, in monitor execute(stat) NameError: name 'stat' is not defined

@velocirobbie velocirobbie added the bug label May 24, 2019

@djgroen

This comment has been minimized.

Copy link
Owner

commented May 24, 2019

I looked into this, and it appears that this functionality got changed in some of Hamid's commits.

Among other things, stat' got changed to job_stat'.

Robbie, could you check if fab archer job_stat works for you? If so, then we can refactor this in a straightforward way.

I'll tag Hamid on this as well.

@velocirobbie

This comment has been minimized.

Copy link
Collaborator Author

commented May 24, 2019

Doesn't seem to work for me because my jobs are not getting put into a '$local_jobsDB_path'. I have never heard of this before, do I need to set it up?

@djgroen

This comment has been minimized.

Copy link
Owner

commented May 24, 2019

No, this to me looks like a refactor that went wrong. Hamid probably completely overlooked that people use these commands also when operating supercomputers directly.

I will reinstate the original stat command for now, but we will need to find a single command that does it for both QCG and SSH-driven jobs.

djgroen added a commit that referenced this issue May 24, 2019

@djgroen

This comment has been minimized.

Copy link
Owner

commented May 24, 2019

I pushed a fix now, and fab archer stat and fab archer monitor work for me now. For you too?

@velocirobbie

This comment has been minimized.

Copy link
Collaborator Author

commented May 24, 2019

Yep both work for me, could you add it to master?

@djgroen

This comment has been minimized.

Copy link
Owner

commented May 24, 2019

Yes. I think I'll merge the branch in altogether. Checking it now :)

@djgroen

This comment has been minimized.

Copy link
Owner

commented May 24, 2019

@velocirobbie Merged it in now. Any luck? :)

@velocirobbie

This comment has been minimized.

Copy link
Collaborator Author

commented May 24, 2019

Still works, leave this open for the issue above

@djgroen

This comment has been minimized.

Copy link
Owner

commented Jun 7, 2019

stat and job_stat now do the same thing. So unless I broke anything I think this issue should be solved.

@djgroen

This comment has been minimized.

Copy link
Owner

commented Jun 7, 2019

in master now, so will close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.