Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no error when get_plugin_path points to nonexistent plugin #97

Closed
djgroen opened this issue May 10, 2019 · 5 comments
Closed

no error when get_plugin_path points to nonexistent plugin #97

djgroen opened this issue May 10, 2019 · 5 comments

Comments

@djgroen
Copy link
Owner

@djgroen djgroen commented May 10, 2019

No description provided.

@NicolasMonnier
Copy link
Collaborator

@NicolasMonnier NicolasMonnier commented Jun 6, 2019

Is that bug fixed Or should I have a look on it?

Loading

@arabnejad
Copy link
Collaborator

@arabnejad arabnejad commented Jun 6, 2019

I made some changes, test it to see if that works for you

Loading

@arabnejad
Copy link
Collaborator

@arabnejad arabnejad commented Jun 10, 2019

update get_plugin_path

def get_plugin_path(name):
    plugin_path = os.path.join(env.localroot, 'plugins', name)
    assert os.path.isdir(plugin_path), \
        "The requested plugin %s does not exist (%s) !!!\n \
        you can install it by :\n\t \
        fab localhost install_plugin:%s" % (name, plugin_path, name)
    return plugin_path

now, if the requested plugin does not exist, you will get an Error

       AssertionError: The requested plugin Fab123 does not exist  !!!
                you can install it by :
       	         fab localhost install_plugin:Fab123

Loading

@NicolasMonnier
Copy link
Collaborator

@NicolasMonnier NicolasMonnier commented Jun 11, 2019

Guess We can close the issue ?

Loading

@djgroen
Copy link
Owner Author

@djgroen djgroen commented Jun 11, 2019

Yes, this is good now.

Loading

@djgroen djgroen closed this Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants