Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FabSim3 automated installation #173

Merged
merged 6 commits into from Mar 12, 2020
Merged

FabSim3 automated installation #173

merged 6 commits into from Mar 12, 2020

Conversation

@arabnejad
Copy link
Collaborator

arabnejad commented Mar 11, 2020

python configure_fabsim.py

arabnejad added 6 commits Feb 18, 2020
@arabnejad arabnejad added this to the VECMA M21 Release milestone Mar 11, 2020
@arabnejad arabnejad requested a review from djgroen Mar 11, 2020
@arabnejad arabnejad linked an issue that may be closed by this pull request Mar 11, 2020
@lgtm-com

This comment has been minimized.

Copy link

lgtm-com bot commented Mar 11, 2020

This pull request introduces 3 alerts when merging 2ae688f into f75d95b - view on LGTM.com

new alerts:

  • 2 for Except block handles 'BaseException'
  • 1 for Unused import
@djgroen

This comment has been minimized.

Copy link
Owner

djgroen commented Mar 12, 2020

@arabnejad I am merging this in, but will you be able to ensure that this stays working in future occasions, accommodating future platform updates and the like? :)

@djgroen djgroen merged commit 6e85cf9 into master Mar 12, 2020
4 checks passed
4 checks passed
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python 3 new alerts
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
@djgroen djgroen deleted the FabSim3_automated_installation branch Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.