Conversation
|
Hi Hamid. Yes, I think fabfile.py should be in FabSim3's root directory, as I think people are very used to running it from there (or from the plugin directories) :). |
|
I think that aside from that minor issue, this code is ready to be merged in. We still have 2-3 weeks to resolve issues if they arise after the merge, and I think we'll detect them rapidly as we're all using FabSim3 extensively at the moment :). |
|
@djgroen |
|
I moved the |
|
This pull request introduces 1 alert and fixes 1 when merging 07bca8c into 29e6b59 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 1 alert and fixes 1 when merging c4ffaf5 into 29e6b59 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 1 alert and fixes 1 when merging 81185ea into 29e6b59 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 1 alert and fixes 1 when merging 44a63fe into 29e6b59 - view on LGTM.com new alerts:
fixed alerts:
|
As we discussed in #203, I did some changes on files and folders in FabSim3 and put all FabSim3 python code files in a separate subdirectory, i.e., `fabsim. The repository's root directory is only used for other stuffs such as installation scripts, py tests, and all manner of other things that aren't actually part of the source code.
@djgroen : Another thing is that, if the user want to use
fabcommand instead offabsim, it should be called insideFabSim3/fabsimorFabSim3/plugins, I already addedfabfile.pyfile in thepluginsfolder, but if you like to have accessfabcommand from root directory, we can movefabfile.pyto the repository's root directory